Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce logging level of task center #1579

Merged
merged 1 commit into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/core/src/task_center.rs
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ impl TaskCenter {
let cancel = cancellation_token().child_token();
let result = self.spawn_inner(kind, name, partition_id, cancel, future);

debug!(
trace!(
kind = ?parent_kind,
name = ?parent_name,
child_kind = ?kind,
Expand Down Expand Up @@ -462,7 +462,7 @@ impl TaskCenter {
join_handle.abort();
} else if task_kind.should_wait_on_cancel() {
// Give the task a chance to finish before logging.
if tokio::time::timeout(Duration::from_secs(1), &mut join_handle)
if tokio::time::timeout(Duration::from_secs(2), &mut join_handle)
.await
.is_err()
{
Expand Down Expand Up @@ -737,7 +737,7 @@ async fn wrapper<F>(
) where
F: Future<Output = anyhow::Result<()>> + Send + 'static,
{
debug!(kind = ?kind, name = ?task.name, "Starting task {}", task_id);
trace!(kind = ?kind, name = ?task.name, "Starting task {}", task_id);

let result = CURRENT_TASK_CENTER
.scope(
Expand Down
1 change: 0 additions & 1 deletion crates/worker/src/partition_processor_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,6 @@ impl PartitionProcessorManager {
tokio::select! {
Some(command) = self.rx.recv() => {
self.on_command(command);
debug!("PartitionProcessorManager shutting down");
}
Some(get_state) = self.incoming_get_state.next() => {
self.on_get_state(get_state);
Expand Down
Loading