[introspection] Set the minimal query parallelism to 2 #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure that the default parallelism for the query engine (datafusion) is at least 2. This value translates to 'target partitions' which is used by datafusion during query execution to control execution concurrency. Setting this value to 1 however causes restatedev#1585, and setting this to high is unadvised in our case, as datafusion is used for low-prio introspection tasks. However once issue restatedev#1585 is resolved, we will return to properly sizing datafusion.
|
related to #1585 |
jackkleeman
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes sure that the default parallelism for the query engine (datafusion) is at least 2. This value translates to 'target partitions' which is used by datafusion during query execution to control execution concurrency. Setting this value to 1 however causes #1585, and setting this to high is unadvised in our case, as datafusion is used for low-prio introspection tasks.
However once issue #1585 is resolved, we will return to properly sizing datafusion.