[239] Ensure sub-resources are also proxied.

[jamezp]

resolves #239

[cghislai]

Thank you!
The only concern I have is with the close method.
It will close the client, so the parent resource instance could not be used anymore afterwards.
I think it would be more intuitive if the subresource was not closable, or that closing it would not have impact on the parent resource lifecycle.

If it is closable, I would expect something like that to work:

try (RootResource root = builder.build(Root.class)) {
  try (SubResource sub1 = root.getSubResource1() {
   //..
  }
  try (SubResource sub2 = root.getSubResource2() {
   //..
  }
}

[jamezp]

Thank you! The only concern I have is with the close method. It will close the client, so the parent resource instance could not be used anymore afterwards. I think it would be more intuitive if the subresource was not closable, or that closing it would not have impact on the parent resource lifecycle.

If it is closable, I would expect something like that to work:

try (RootResource root = builder.build(Root.class)) {
  try (SubResource sub1 = root.getSubResource1() {
   //..
  }
  try (SubResource sub2 = root.getSubResource2() {
   //..
  }
}

That's a good point. I did it mainly because https://download.eclipse.org/microprofile/microprofile-rest-client-3.0/microprofile-rest-client-spec-3.0.html#lifecycle indicates a client must implement Closeable, but I guess a sub-resource is different than a client. I'll undo that part as I agree with you.

I'll also remove the RestClientProxy interface too. I'll add some more tests around closing too.

[cghislai]

lgtm, thank you!

[jamezp]

@cghislai Thank you so much for your help on this. I'll get a release out by next week.