Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ApplyExperienceMultipliers Undefined Behavior #5318

Closed
ghoulslash opened this issue Sep 3, 2024 · 0 comments · Fixed by #5421
Closed

ApplyExperienceMultipliers Undefined Behavior #5318

ghoulslash opened this issue Sep 3, 2024 · 0 comments · Fixed by #5421
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet

Comments

@ghoulslash
Copy link
Collaborator

Description

ApplyExperienceMultipliers calls GetBattlerAffectionHearts(expGetterMonId), but expGetterMonId is a party index, not a battler Id. Probably should be GetMonAffectionHearts(&gPlayerParty[expGetterMonId]). This is a reminder to correct this behavior

Version

1.9.1 (Latest release)

Upcoming/master Version

No response

Discord contact info

No response
@ghoulslash ghoulslash added bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet labels Sep 3, 2024
@Bassoonian Bassoonian mentioned this issue Sep 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug category: battle-mechanic Pertains to battle mechanics status: unconfirmed This bug has not been reproduced yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix affection check for exp multiplier Bassoonian/pokeemerald-expansion
1 participant
@ghoulslash