Fix AI tests using PASSES_RANDOMLY #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawkkie
added
bugfix
|
I just want to wait for @mrgriffin to double check this because it's entirely their code and they'll have the eye for making sure I haven't missed anything lol |
No problem 👍 |
mrgriffin
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AI tests weren't having their state reset between PASSES_RANDOMLY runs, which meant that every run but the first one was checking the wrong information. This PR fixes that behaviour, and fixes the one AI test that used PASSES_RANDOMLY while it was broken. This is all mgriffin not me :)
People who collaborated with me in this PR
@mrgriffin Did the whole thing :D
Discord contact info
@Pawkkie