Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change demo server #67

Closed
rCarto opened this issue Nov 30, 2020 · 4 comments
Closed

Change demo server #67

rCarto opened this issue Nov 30, 2020 · 4 comments

Comments

@rCarto
Copy link
Member

rCarto commented Nov 30, 2020

Change the demo server for https://routing.openstreetmap.de as it allows to request foot/bike/car routes/tables/trips.

This version use hacks to allow different profiles (Used profiles section in https://routing.openstreetmap.de/about.html)

  • It implies to adapt the package code to accommodate both profile selection for demo server (via routed-foot/routed-car/routed-bike URL prefixes) and local server (via driving/walk/bike URL prefixes).
    IMO demo server related changes should be invisible to users and profile selection should still pass through options(osrm.profile="walk/bike/driving"). But maybe we should think about another solution to use osrm functions without loading the package (stplanr use-case I think @Robinlovelace ?).
  • Update documentation accordingly (link to https://routing.openstreetmap.de/about.html, explicit recommendation about API usage). In readme and package documentation.
@Robinlovelace
Copy link
Contributor

I can have a go at putting in a PR if that would be useful @rCarto.

@rCarto
Copy link
Member Author

rCarto commented Nov 30, 2020

Yes, sure!

@Robinlovelace
Copy link
Contributor

First attempt: see commit above!

@rCarto
Copy link
Member Author

rCarto commented Dec 3, 2020

Thank you, I'll have a look at it asap. I'll try to drop a new release next week.

@rCarto rCarto closed this as completed in 16ebe06 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants