consider image rotation (exif)

[DoKraus]

Regarding #23:

Seems to work now, but it is rather slow on mobile devices (tested with iPhone 4S, iOS 10.3.1).
I assume that's because of the canvas' toDataURL-method.
I reduced that problem and used the same filetype as the selected image. So image/jpeg would not converted to image/png - which accelerates the processing.

For images without rotation, the passed base64 string is used, so that no canvas-working is needed.

[ribizli]

Sorry for the late reaction. I like the solution, but still thinking about if I want to provide this as included default. I'm thinking to let users decide, and let them add this through a plugin (provider).
Unfortunately I'm busy now, so I cannot really work on this project soon.

[pareshvarde]

It's been a more than a year. Can someone please merge this to master?

[ribizli]

Hi, sorry, I don't really want to tightly couple the exif code with this library. I'd rather allow it as a plug-in. But still need to work on it. Since nobody has pushed this too hard until now, I thought it is not relevant anymore. Still I cannot promise anything for now, I'm thinking about some multi provider injection plug-in system working on data urls in a chained way.

[pareshvarde]

Thanks. An optional plug in would help. Please do it when you get a chance. Appreciate your help. On Fri, Jul 27, 2018 at 1:25 AM, ribizli<[email protected]> wrote: Hi, sorry, I don't really want to tightly couple the exif code with this library. I'd rather allow it as a plug-in. But still need to work on it. Since you haven't pushed this too hard until now, I thought it is not relevant anymore. Still I cannot promise anything for now, I'm thinking about some multi provider injection plug-in system working on data urls in a chained way. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[jpike88]

I don't really want to tightly couple the exif code with this library

EXIF metadata exists on loads of photos, your design decision makes this library only handle 50% of the equation. I assumed it handled orientation by default, why wouldn't it?

[ribizli]

@jpike88 this repo is not maintained anymore, file an issue rather here: https:/ribizli/ngx-image2dataurl

In that project I've designed a plugin system(ImageFileProcessor) so one can plug in EXIF support.

[jpike88]

I release a package called ngx-image2dataurl-orientation with the fix, it's based off that new repo. All good

[ribizli]

It's you call, however I'd prefer just releasing a plugin for the ngx-image2dataurl package.