Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make count_entities test work with igraph current version #512

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jan 23, 2024

Fix #500

However it makes the example a bit ridiculous?!

@krlmlr

p = 1 / 5,
edges_between = 1,
set_seed = 23)
island_size = 1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this if I follow correctly we created 4 unconnected islands of 1 elements each so there are 4 strongly connected elements. however are they connected to themselves then?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go with this for now and solve the immediate problem (of fixing a revdep failure for igraph). I can always revise the tests later.

@rich-iannone
Copy link
Owner

Thanks @maelle , I'll merge right now!

@rich-iannone rich-iannone merged commit f2917d7 into rich-iannone:main Jan 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test relies on specific output from sample_islands() for given seed
2 participants