Fix diagnostic notifications override on clients #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On diagnostics notification there is the `-` file that was not being translated to the real filename when selecting the diagnostics results from a %hash<filename => diag>, causing a notification with erroneous diagnostics (empty, as no errors existed for filename `-`), overriding any other notification for that same file depending on the order of delivery to the client. This patch adds just a simple reassignment to $filename using the $uri as basis, since it was correct even for the `-` filename.
On sending diagnostic notifications two exact same for-loops were nested on each other, causing duplicated notifications on clients. This commit fixes it by removing one of the loops.
|
@richterger this PR solves a simple bug with an obvious fix, it would help many using both vscode and vim/nvim through |
|
Using always the uri is not an good idea, also it works most the time. |
|
@richterger I dropped a comment in #184, please check it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the diagnostic notifications getting overridden on clients due to multiple notifications for the same file with different diagnostic results and also notifications being sent twice for each file due to a erroneous nested loop.
Fixes #184