Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Source YAML Editor #2770

Merged
merged 64 commits into from
Aug 3, 2023
Merged

Add Source YAML Editor #2770

merged 64 commits into from
Aug 3, 2023

Conversation

ericpgreen2
Copy link
Contributor

@ericpgreen2 ericpgreen2 commented Jul 12, 2023 •
edited
Loading

This PR introduces a YAML editor to the Source workspace. This includes 3 major items:

  1. Introduce the YAML editor (Notion PRD)
  2. Add/revisit relevant CTAs (Notion PRD)
  3. Properly display error messages (Notion PRD)

This PR does not modify the navigation from the Add Source modal (Notion PRD). That will be handled in a follow-on PR.

@ericpgreen2 ericpgreen2 mentioned this pull request Jul 12, 2023
Closed
@ericpgreen2
Fix merge
41e5561
@ericpgreen2
Fix imports
1bac186
@ericpgreen2
Source store: initialize at top-level, use context, simplify
05bf60c
@ericpgreen2
Add "Save and refresh" button
6291ec1
@ericpgreen2
Make not-saved indicator responsive to new server state
c15ae47
@ericpgreen2
Pull errors from file artifact store
39e239b
@ericpgreen2
Remove workaround
8ef6384
@ericpgreen2
Make not-saved indicator a gray dot
58416e5
@ericpgreen2
Use 'Unsaved' not 'NotSaved'
732225b
@ericpgreen2
Add dialog when leaving unsaved source
500319d
@ericpgreen2
Simplify source store
a759120
@ericpgreen2
Remove old code
4ea8ea6
@ericpgreen2
Disable modal behavior that focuses trigger on close
2377d79
@ericpgreen2
Merge branch 'main' into ui-source-yaml-2
01459cb
@ericpgreen2
Wait for confirmation before navigating away from source
35b0aeb
@ericpgreen2
Remove unused prop
e2b1aaa
@ericpgreen2
Fix width
fbba872
@ericpgreen2
Add back currentHref optimization, just in case
f138a33
@ericpgreen2
Refactor "HorizontalSplitter" into component
5380a9e
@ericpgreen2
Use HorizontalSplitter in Source workspace
2f3a95a
@ericpgreen2
Update package lock
24a5a2f
@ericpgreen2
Disable refresh button when there are errors
7833640
@ericpgreen2
Don't forward unused event
a713f1d
@ericpgreen2
Rename function
48f2a92
@ericpgreen2
Add line-specific errors
74dcc34
@ericpgreen2
Fix dialog not closing
bb2128f
@ericpgreen2
e2e tests: use a common updateCodeEditor fn
43fcf4e
@ericpgreen2
Add an e2e test for editing sources
33c50dd
@ericpgreen2 ericpgreen2 mentioned this pull request Jul 24, 2023
Merged
skokenes
skokenes approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@skokenes skokenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ericpgreen2 ericpgreen2 merged commit c4ef4df into main Aug 3, 2023
2 checks passed
@ericpgreen2 ericpgreen2 deleted the ui-source-yaml-2 branch August 3, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skokenes skokenes skokenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericpgreen2 @skokenes @nishantmonu51 @hamilton