Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timezone support to dashboard #2775

Merged
merged 30 commits into from
Jul 31, 2023
Merged

Add timezone support to dashboard #2775

merged 30 commits into from
Jul 31, 2023

Conversation

djbarnwal
Copy link
Member

@djbarnwal djbarnwal commented Jul 14, 2023

Add timezone support to Dashboard

List of tasks - #2758

@djbarnwal djbarnwal marked this pull request as ready for review July 22, 2023 14:40
Copy link
Collaborator

@AdityaHegde AdityaHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge after fixing the small nits.

@djbarnwal djbarnwal merged commit a3afec1 into main Jul 31, 2023
3 checks passed
@djbarnwal djbarnwal deleted the timezone-support branch July 31, 2023 09:23
djbarnwal added a commit that referenced this pull request Aug 3, 2023
* Basic timezone support added

* Use abbreviation mapping

* Use abbreviation for selector label

* Selector as per mocks

* Align comparisons selector

* Rename vars and text

* Decreasing x padding for icon menu item

* add timezone to quickstart template

* Add available time zones key

* Update time zone selector tooltip

* Add selectedTimezone to proto, label changes

* Timezone support for chart elements

* Convert custom calendar dates based on zone

* Clean up PR

* Fix broken unit tests

* More test fixes

* All time charts edge fix

* Save timezone preferene localy

* Fix all tests

* fix: wait for menu to close in e2e tests

* Move out user preference store

* Remove unused imports

---------

Co-authored-by: Speros Kokenes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants