Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime: Support template resolution in source properties #3712

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Runtime: Support template resolution in source properties #3712

merged 5 commits into from
Dec 21, 2023

Conversation

k-anshul
Copy link
Member

closes #3203

@k-anshul k-anshul self-assigned this Dec 18, 2023
begelundmuller
begelundmuller requested changes Dec 18, 2023
View reviewed changes
runtime/reconcilers/source.go Outdated Show resolved Hide resolved
runtime/reconcilers/source.go Outdated Show resolved Hide resolved
runtime/reconcilers/util.go Outdated Show resolved Hide resolved
runtime/reconcilers/util.go Outdated Show resolved Hide resolved
begelundmuller
begelundmuller approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begelundmuller begelundmuller merged commit a340078 into main Dec 21, 2023
4 checks passed
@begelundmuller begelundmuller deleted the src_templating branch December 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime: Support template resolution in source properties
2 participants
@k-anshul @begelundmuller