Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime: Fix malformed WHERE clauses for security policies with OR in the row filter #3752

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Runtime: Fix malformed WHERE clauses for security policies with OR in the row filter #3752

merged 3 commits into from
Dec 28, 2023

Conversation

begelundmuller
Copy link
Contributor

@begelundmuller begelundmuller commented Dec 28, 2023 •
edited
Loading

  • Ensures correct precedence of filters when a security policy uses OR
  • Ensures security policies are always applied even when a nil filter is passed (this closes a security loophole, but didn't impact the user experience since an empty non-nil filter is always passed)

Fixes issue reported in Slack.

@begelundmuller begelundmuller changed the title Runtime: fix malformed SQL for security policies with 'OR' Runtime: Fix malformed WHERE clauses for security policies with 'OR' Dec 28, 2023
@begelundmuller begelundmuller changed the title Runtime: Fix malformed WHERE clauses for security policies with 'OR' Runtime: Fix malformed WHERE clauses for security policies with OR in the row filter Dec 28, 2023
@begelundmuller begelundmuller self-assigned this Dec 28, 2023
@begelundmuller begelundmuller merged commit 737fce3 into v0.38 Dec 28, 2023
4 checks passed
@begelundmuller begelundmuller deleted the begeundmuller/fix-security-policy-checks branch December 28, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@begelundmuller begelundmuller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@begelundmuller