fix: alternate connector support for visual metrics #5909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
added
the
blocker
|
Just adding to this per a Slack thread with @ericpgreen2 -- will this allow the drop-down menu to be populated correctly in the Visual Metrics Editor? (For projects that reference a CH table, the drop-down is currently null).
|
|
Yes |
ericpgreen2
approved these changes
Oct 16, 2024
| @@ -44,7 +44,7 @@ export function prettyResourceKind(kind: string) { | |||
| export function useResource<T = V1Resource>( | |||
| instanceId: string, | |||
| name: string, | |||
| kind: ResourceKind, | |||
| kind: ResourceKind | undefined, | |||
There was a problem hiding this comment.
Can we avoid setting this to undefined? It feels like it breaks the semantics
ericpgreen2
pushed a commit
that referenced
this pull request
Oct 16, 2024
* wip * cleanup * wip * cleanup * feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.