Skip to content
This repository has been archived by the owner on Nov 24, 2021. It is now read-only.

Add format checking #10

Closed
sublimator opened this issue May 28, 2016 · 5 comments
Closed

Add format checking #10

sublimator opened this issue May 28, 2016 · 5 comments

Comments

@sublimator
Copy link
Contributor

The primary client of this module is RippleAPI which checks/enforces its own schema, however it would still be useful to add per TransactionType format checking to encodeForSigning and encodeForMultiSigning

@intelliot
Copy link
Contributor

Should we just throw if the format check fails?

@sublimator
Copy link
Contributor Author

I would

@sublimator
Copy link
Contributor Author

I think @wilsonianb might be using it for validator manifests, which have no TransactionType/LedgerEntryType so keep that in mind.

@sublimator
Copy link
Contributor Author

So probably you could get away with full format checking if LedgerEntryType/TransactionType field is in the object, $somehow detect a validator manifest and handle accordingly, otherwise require at least one serialized field (https:/ripple/ripple-binary-codec/blob/master/src/enums/definitions.json#L40)

@intelliot
Copy link
Contributor

Replaced by XRPLF/xrpl.js#1807

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants