This repository has been archived by the owner on Nov 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Add format checking #10
Comments
Should we just |
I would |
I think @wilsonianb might be using it for validator manifests, which have no TransactionType/LedgerEntryType so keep that in mind. |
So probably you could get away with full format checking if LedgerEntryType/TransactionType field is in the object, $somehow detect a validator manifest and handle accordingly, otherwise require at least one serialized field (https:/ripple/ripple-binary-codec/blob/master/src/enums/definitions.json#L40) |
sublimator
referenced
this issue
Jul 27, 2019
Replaced by XRPLF/xrpl.js#1807 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The primary client of this module is RippleAPI which checks/enforces its own schema, however it would still be useful to add per TransactionType format checking to
encodeForSigning
andencodeForMultiSigning
The text was updated successfully, but these errors were encountered: