Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force boost static linking for macos builds #2334

Closed
wants to merge 1 commit into from
Closed

Force boost static linking for macos builds #2334

wants to merge 1 commit into from

Conversation

mellery451
Copy link
Contributor

No description provided.

seelabs
seelabs approved these changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks good; tested both static and non-static builds on linux.

@ripplelabs-jenkins
Copy link
Collaborator

Jenkins Build Summary

Built from this commit

Built at 20180117 - 20:41:07

Test Results

Build Type Result Status
coverage 975 cases, 0 failed, t: 614s PASS ✅
clang.debug.unity 975 cases, 0 failed, t: 383s PASS ✅
gcc.debug.unity 975 cases, 0 failed, t: 431s PASS ✅
clang.debug.nounity 973 cases, 0 failed, t: 717s PASS ✅
gcc.debug.nounity 973 cases, 0 failed, t: 312s PASS ✅
clang.release.unity 974 cases, 0 failed, t: 470s PASS ✅
gcc.release.unity 974 cases, 0 failed, t: 503s PASS ✅

scottschurr
scottschurr approved these changes Jan 17, 2018
View reviewed changes
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me. I nuked my cmake build trees and did both a unity/release and no-unity/debug cmake build. Both built and linked just fine. Both successfully ran unit tests.

@scottschurr scottschurr added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Jan 17, 2018
@mellery451 mellery451 closed this Jan 18, 2018
@mellery451 mellery451 deleted the mellery-mac-static branch January 18, 2018 21:49
@scottschurr
Copy link
Collaborator

Incorporated in 0.90.0-b4 as 2a4eac6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seelabs seelabs seelabs approved these changes

@scottschurr scottschurr scottschurr approved these changes

@HowardHinnant HowardHinnant Awaiting requested review from HowardHinnant

Assignees
No one assigned
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mellery451 @ripplelabs-jenkins @scottschurr @seelabs