Update cmake so that rippled can build as a submodule #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjcobb23 In short, if you can build rippled in all of the current configurations, then it works. |
cjcobb23
approved these changes
Jun 16, 2020
miguelportilla
approved these changes
Jun 16, 2020
ximinez
added
the
Passed
|
Squashed and set the "passed" flag. |
This was referenced Jun 25, 2020
This was referenced Jun 25, 2020
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively trivial fix to the build system which allows rippled or parts of it to be built when included as a submodule to another project. There is also the option used in dbc8f14, but this seemed simpler.
This change is