ignore_default option on account_lines #3980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nbougalis FYI. This would help reduce the data fetched for all XUMM users significantly on "mixed accounts" (issuing and holding) like we see a lot of these days. |
nbougalis
added
the
Passed
nbougalis
approved these changes
Nov 17, 2021
|
@manojsdoshi I'm proposing this for inclusion into 1.8.0-rc3, since it helps reduce the load for Xumm (and the server). |
|
@manojsdoshi @nbougalis What's the status on this? |
ximinez
requested changes
Dec 17, 2021
Comment on lines
+210
to
+232
| bool ignore = false; | ||
| if (visitData.ignoreDefault) | ||
| { | ||
| if (sleCur->getFieldAmount(sfLowLimit).getIssuer() == | ||
| visitData.accountID) | ||
| ignore = | ||
| !(sleCur->getFieldU32(sfFlags) & lsfLowReserve); | ||
| else | ||
| ignore = !( | ||
| sleCur->getFieldU32(sfFlags) & lsfHighReserve); | ||
| } | ||
|
|
||
| auto const line = | ||
| RippleState::makeItem(visitData.accountID, sleCur); | ||
| if (line != nullptr && | ||
| (!visitData.hasPeer || | ||
| visitData.raPeerAccount == line->getAccountIDPeer())) | ||
| { | ||
| visitData.items.emplace_back(line); | ||
| if (!ignore) | ||
| visitData.items.emplace_back(line); | ||
|
|
||
| visitData.lastFound = line; | ||
| visitData.foundCount++; |
There was a problem hiding this comment.
I think this would be somewhat more readable if ignore was include. So it would look something like:
bool include = true;
if (visitData.ignoreDefault)
{
if (sleCur->getFieldAmount(sfLowLimit).getIssuer() ==
visitData.accountID)
include = sleCur->getFieldU32(sfFlags) & lsfLowReserve;
else
ignore = sleCur->getFieldU32(sfFlags) & lsfHighReserve;
}
[...]
{
if (include)
visitData.items.emplace_back(line);
[...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Add
ignore_defaultflag toaccount_lines. This flag suppresses the output of incoming trustlines in default state.Context of Change
Users of XUMM often have unwanted incoming trustlines in default state, these are not useful in the vast majority of cases. Ability to suppress these in
account_linessaves bandwidth and resources.Type of Change