Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With the update to v1.10.0 there is no way to compile this tool #41

Closed
nmiceli-simtlix opened this issue Mar 21, 2023 · 10 comments
Closed

Comments

@nmiceli-simtlix
Copy link

When trying to compile the "old" way, you would get an error:

Could not find a package configuration file provided by "lz4" with any of
the following names:

lz4Config.cmake
lz4-config.cmake

There are no conanfiles for this tool. 
@shichengripple001
Copy link

getting the same error

@legleux legleux changed the title With the update to v1.10.0 there is now way to compile this tool With the update to v1.10.0 there is no way to compile this tool Mar 23, 2023
@legleux
Copy link
Collaborator

legleux commented Mar 23, 2023

The validator-keys binary is provided in rippled packages.
It can also be built from the rippled repo if you provide your CMake call with -Dvalidator_keys=ON.
Otherwise yes, this project needs to be updated and is a good candidate for the libxrpl Conan package XRPLF/rippled#4449

@shichengripple001
Copy link

shichengripple001 commented Mar 28, 2023

I have tried build with
cmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -Dvalidator_keys=ON -DCMAKE_BUILD_TYPE=Release ..

but seems only rippled binary is built, I do see there is a validator-keys folder got generated, but it is empty

@kamzar1
Copy link

kamzar1 commented Apr 21, 2023

Same error.
Sadly came up after hours of pulling and building tons of dependencies.
Including an executable x86_64 binary in release would have saved a lot of work.

@legleux
Copy link
Collaborator

legleux commented Apr 25, 2023

Same error. Sadly came up after hours of pulling and building tons of dependencies. Including an executable x86_64 binary in release would have saved a lot of work.

I'm not sure what you're building manually, you should let Conan build all the dependencies for less headaches.

A validator-keys binary is provided in both the rpm and deb packages next to the rippled binary in /opt/ripple/bin so you don't even have to build it from this repo or the rippled repo.

@legleux
Copy link
Collaborator

legleux commented Apr 25, 2023

I have tried build with cmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -Dvalidator_keys=ON -DCMAKE_BUILD_TYPE=Release ..

but seems only rippled binary is built, I do see there is a validator-keys folder got generated, but it is empty

Sorry, the validator-keys target is not built by default. You must add it as a target during the CMake build step:

cmake --build <build_dir> --target validator-keys

@praja83
Copy link

praja83 commented Jun 20, 2023

I have tried build with cmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -Dvalidator_keys=ON -DCMAKE_BUILD_TYPE=Release ..
but seems only rippled binary is built, I do see there is a validator-keys folder got generated, but it is empty

Sorry, the validator-keys target is not built by default. You must add it as a target during the CMake build step:

cmake --build <build_dir> --target validator-keys

Sorry, I do not understand. What should I do? I am getting the "lz4" error on Ubuntu after cmake -DCMAKE_BUILD_TYPE=Release ../..
Rippled server is running, but I did not install rippled from repo.
Thanks

@legleux
Copy link
Collaborator

legleux commented Jun 21, 2023

Do not try to build validator-keys from this repository.
In the rippled project, during the CMake configure step, provide the option
-Dvalidator_keys=ON, then during the build step add the the validator-keys target to the build command.
cmake --build <build_dir> --target validator-keys

For example:

conan install . -if "${BUILD_DIR}" \
    --build missing \
    --settings build_type=Debug \
    --profile gcc-11

cmake -B "${BUILD_DIR}" \
    -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake \
    -Dvalidator_keys=ON \
    -DCMAKE_BUILD_TYPE=Debug  .

cmake --build build --target validator-keys --parallel $(echo "$(nproc) - 2" | bc)`

Use whatever conan profile, BUILD_DIR and CMAKE_BUILD_TYPE you see fit.

@praja83
Copy link

praja83 commented Jun 21, 2023

Do not try to build validator-keys from this repository. In the rippled project, during the CMake configure step, provide the option -Dvalidator_keys=ON, then during the build step add the the validator-keys target to the build command. cmake --build <build_dir> --target validator-keys

For example:

conan install . -if "${BUILD_DIR}" \
    --build missing \
    --settings build_type=Debug \
    --profile gcc-11

cmake -B "${BUILD_DIR}" \
    -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake \
    -Dvalidator_keys=ON \
    -DCMAKE_BUILD_TYPE=Debug  .

cmake --build build --target validator-keys --parallel $(echo "$(nproc) - 2" | bc)`

Use whatever conan profile, BUILD_DIR and CMAKE_BUILD_TYPE you see fit.

Thanks, I was facing a lot of errors and conflicts, but was able to install conan...
after that I see:

CMake Error at CMakeLists.txt:87 (find_package):
By not providing "FindRocksDB.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "RocksDB", but
CMake did not find one.

Could not find a package configuration file provided by "RocksDB" with any
of the following names:

RocksDBConfig.cmake
rocksdb-config.cmake

Add the installation prefix of "RocksDB" to CMAKE_PREFIX_PATH or set
"RocksDB_DIR" to a directory containing one of the above files. If
"RocksDB" provides a separate development package or SDK, be sure it has
been installed.

@legleux
Copy link
Collaborator

legleux commented Jun 21, 2023

I'm going to close this issue as this discussion is going in a direction that has nothing to do with the validator-keys project.
Make sure you're closely following the BUILD.md and if you're still having issues, jump on the XRPL Developer Discord channel to get some more help and be sure you tell people your exact setup and commands you've run.

@legleux legleux closed this as completed Jun 21, 2023
@legleux legleux closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants