Only enter debug mode once with -H flag (halt_on_reset) #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deferring review to @rtwfroody. |
rtwfroody
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
This change is good. At one point halt was a bit in dcsr, so when the debugger does practically anything it would end up clearing the bit. Now the bit isn't there anymore so it needs to be cleared some other way. Probably the bit should be moved out of the dcsr structure here altogether.
aswaterman
approved these changes
Sep 26, 2024
YenHaoChen
added a commit
to YenHaoChen/riscv-isa-sim
that referenced
this pull request
Sep 27, 2024
|
An other PR is provided to move dcsr::halt out of the dcsr structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dcsr->halt indicates whether to enter debug mode due to halt_on_reset. The variable only depends on whether the -H flag exists or not.
This commit proposes entering the debug mode only once and resetting the dcsr->halt. (Without the commit, the step() will always enter the debug mode with the -H flag.)
I need help confirming that the debugging software expects this behavior. @rtwfroody