Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar Cryptography v1.0.0-rc1 style issues #108

Open
pmassolino opened this issue Aug 6, 2021 · 0 comments
Open

Scalar Cryptography v1.0.0-rc1 style issues #108

pmassolino opened this issue Aug 6, 2021 · 0 comments
Assignees
Labels
public-review For all comments related to the public review process

Comments

@pmassolino
Copy link

Hello, I gave a quick read on the Scalar Cryptography v1.0.0-rc1 and I found very minor non-consistent writing style.
In some parts of the text some words have uppercase in the first letter for all important words, while later in a similar place it only has uppercase in the beginning of a sentence. I would just adopt all letters are lowercase except the first, acronyms etc.
Here is what I found out.

Page 7, Sections 2.4 and 2.5:
All AES instructions name are lowercase, except:
AES Decrypt KeySchedule MixColumns (RV64)
AES Key Schedule Instruction 1 (RV64)
AES Key Schedule Instruction 2 (RV64)

AES Key Schedule Instruction 1 (RV64)
AES Key Schedule Instruction 2 (RV64)

Pages 8, 9: "Permutation" starts with uppercase, while previous "multiply" is lowercase.
Cross-bar Permutation instructions.
NIST Algorithm suite extension.

Page 62:
Table 1, mode S in the description: "an Illegal Instruction Exception"
While in the text below it is written all in lowercase "an illegal instruction exception"

Also, table 1 in page 62 is the first table with a description, while all previous tables didn't have any description. I would remove the description, since it doesn't add much and makes it consistent with previous tables.

@ben-marshall ben-marshall self-assigned this Aug 6, 2021
@ben-marshall ben-marshall added the public-review For all comments related to the public review process label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public-review For all comments related to the public review process
Projects
None yet
Development

No branches or pull requests

2 participants