Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual unregistration when scale-in #2561

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

WanYixian
Copy link
Contributor

Description

Remove manual unregistration of the compute node when scale-in

Related code PR

risingwavelabs/risingwave#17802

Related doc issue

Resolve #2418

Rendered preview

Checklist

  • I have checked the doc site preview, and the updated parts look good.
  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (emile-00, hengm3467, & WanYixian).

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2561.d2fbku9n2b6wde.amplifyapp.com

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that automatic unregistration is only available for versions later than v2.0? Rest LGTM.

Copy link
Contributor

@ShanlanLi ShanlanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WanYixian WanYixian merged commit 17f0011 into main Sep 2, 2024
3 checks passed
@WanYixian WanYixian deleted the wyx/resolve_2418 branch September 2, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat: also gracefully shutdown on SIGTERM
3 participants