Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approx_percentile in the aggregate functions #2572

Merged
merged 5 commits into from
Sep 5, 2024
Merged

Conversation

WanYixian
Copy link
Contributor

@WanYixian WanYixian commented Sep 4, 2024

Description

Add approx_percentile in the aggregate functions.

@kwannoel, now it's under "General-purpose aggregate functions" section, let me know if it's more suitable for other categories like "Aggregate functions for statistics" "Ordered-set aggregrate functions", thanks!

If more info is required for this user-facing change, pls feel free to add.

image

Related code PR

risingwavelabs/risingwave#17873
risingwavelabs/risingwave#17814

Related doc issue

Resolve #2439
Resolve #2427

Rendered preview

Checklist

  • I have checked the doc site preview, and the updated parts look good.
  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (emile-00, hengm3467, & WanYixian).

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2572.d2fbku9n2b6wde.amplifyapp.com

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put it under ordered set aggregate functions? Thanks 😊

Copy link
Contributor

@ShanlanLi ShanlanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WanYixian WanYixian merged commit 6c4092c into main Sep 5, 2024
3 checks passed
@WanYixian WanYixian deleted the wyx/resolve_2439 branch September 5, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants