Skip to content

Commit

Permalink
fix(frontend): fix changelog append_only (#17583)
Browse files Browse the repository at this point in the history
  • Loading branch information
xxhZs authored Jul 5, 2024
1 parent 1b286ce commit dc1fe45
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 0 additions & 3 deletions integration_tests/snowflake-sink/upsert/create_sink.sql
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,4 @@ CREATE SINK snowflake_sink FROM ss_mv WITH (
snowflake.aws_secret_access_key = 'EXAMPLE_SECRET_KEY',
snowflake.aws_region = 'EXAMPLE_REGION',
snowflake.s3_path = 'EXAMPLE_S3_PATH',
-- depends on your mv setup, note that snowflake sink *only* supports
-- `append-only` mode at present.
force_append_only = 'true'
);
3 changes: 2 additions & 1 deletion src/frontend/src/optimizer/plan_node/stream_changelog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ impl StreamChangeLog {
let base = PlanBase::new_stream_with_core(
&core,
dist,
input.append_only(),
// The changelog will convert all delete/update to insert, so it must be true here.
true,
input.emit_on_window_close(),
watermark_columns,
);
Expand Down

0 comments on commit dc1fe45

Please sign in to comment.