fix select sql

risingwavelabs · Aug 30, 2023 · e7b76ff · e7b76ff
1 parent 78cd99c
commit e7b76ff
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/connector/src/source/external.rs b/src/connector/src/source/external.rs
@@ -330,16 +330,25 @@ impl MySqlExternalTableReader {
  primary_keys: Vec<String>,
  ) {
  let order_key = primary_keys.iter().join(",");
+ let field_list = self
+ .rw_schema
+ .fields
+ .iter()
+ .map(|f| f.name.clone())
+ .join(",");
+
  let sql = if start_pk.is_none() {
  format!(
- "SELECT * FROM {} ORDER BY {}",
+ "SELECT {} FROM {} ORDER BY {}",
+ field_list,
  self.get_normalized_table_name(&table_name),
  order_key
  )
  } else {
  let filter_expr = Self::filter_expression(&primary_keys);
  format!(
- "SELECT * FROM {} WHERE {} ORDER BY {}",
+ "SELECT {} FROM {} WHERE {} ORDER BY {}",
+ field_list,
  self.get_normalized_table_name(&table_name),
  filter_expr,
  order_key