Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(stream): pk indices consistency between optimizer and executor #12310

Closed
26 tasks done
Tracked by #12459
stdrc opened this issue Sep 14, 2023 · 0 comments
Closed
26 tasks done
Tracked by #12459

bug(stream): pk indices consistency between optimizer and executor #12310

stdrc opened this issue Sep 14, 2023 · 0 comments
Assignees
Labels
type/bug Something isn't working
Milestone

Comments

@stdrc
Copy link
Contributor

stdrc commented Sep 14, 2023

Now we don't have a way to force backend executor construct its ExecutorInfo with the pk indices derived in optimizer. And thus many executors derive pk indices again in their new with input.pk_indices(). This can lead to bugs like #12282 (fixed by #12304) and #10879 (fixed by #11276).

See #12763, enabling the assertion suggested by @BugenZhao will make e2e failed. We may need to revisit every executor to ensure the correctness.

Failed e2e and and the panicked executors:

  • e2e_test/streaming/aggregate/hdr_approx_percentile.slt: TopN
  • e2e_test/streaming/append_only.slt: Materialize
  • e2e_test/streaming/bug_fixes/hop_window_update_10495.slt: Materialize
  • e2e_test/streaming/bug_fixes/issue_12299.slt: Materialize
  • e2e_test/streaming/bug_fixes/issue_5285.slt: TopN
  • e2e_test/streaming/bug_fixes/issue_5825.slt: TopN
  • e2e_test/streaming/bug_fixes/issue_8084.slt: Materialize
  • e2e_test/streaming/bug_fixes/issue_8570.slt: TopN
  • e2e_test/streaming/bug_fixes/mv_on_singleton_mv_4153.slt: TopN
  • e2e_test/streaming/delta_join/delta_join_snapshot.slt: Materialize
  • e2e_test/streaming/delta_join/delta_join_snapshot_no_index.slt: Materialize
  • e2e_test/streaming/delta_join/delta_join_upstream.slt: Materialize
  • e2e_test/streaming/delta_join/delta_join_upstream_no_index.slt: Materialize
  • e2e_test/streaming/group_top_n/main1.slt: TopN
  • e2e_test/streaming/index.slt: Materialize
  • e2e_test/streaming/natural_and_cross_join.slt: Materialize
  • e2e_test/streaming/nexmark_snapshot.slt: TopN
  • e2e_test/streaming/nexmark_upstream.slt: TopN
  • e2e_test/streaming/order_by.slt: TopN
  • e2e_test/streaming/outer_join.slt: Materialize
  • e2e_test/streaming/struct_table.slt: Materialize
  • e2e_test/streaming/temporal_join/temporal_join.slt: Materialize
  • e2e_test/streaming/temporal_join/temporal_join_watermark.slt: Materialize
  • e2e_test/streaming/temporal_join/temporal_join_with_index.slt: Materialize
  • e2e_test/streaming/tpch_snapshot.slt: TopN
  • e2e_test/streaming/tpch_upstream.slt: TopN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant