Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node_fmt): 4 more impls for Distill #10291

Merged
merged 1 commit into from
Jun 12, 2023
Merged

refactor(plan_node_fmt): 4 more impls for Distill #10291

merged 1 commit into from
Jun 12, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This is a folllllow up of #10132, #10155, #10157, #10253, #10280, #10281.

image

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 requested a review from st1page June 12, 2023 12:15
@github-actions github-actions bot added type/refactor user-facing-changes Contains changes that are visible to users labels Jun 12, 2023
@ice1000 ice1000 enabled auto-merge June 12, 2023 12:28
@ice1000 ice1000 added this pull request to the merge queue Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #10291 (5276264) into main (3d54df9) will decrease coverage by 0.02%.
The diff coverage is 25.35%.

@@            Coverage Diff             @@
##             main   #10291      +/-   ##
==========================================
- Coverage   70.55%   70.53%   -0.02%     
==========================================
  Files        1243     1243              
  Lines      212777   212822      +45     
==========================================
- Hits       150119   150113       -6     
- Misses      62658    62709      +51     
Flag Coverage Δ
rust 70.53% <25.35%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/optimizer/plan_node/logical_multi_join.rs 85.14% <0.00%> (-1.07%) ⬇️
...frontend/src/optimizer/plan_node/logical_insert.rs 64.63% <20.00%> (-4.51%) ⬇️
...c/frontend/src/optimizer/plan_node/logical_join.rs 89.20% <20.83%> (-1.10%) ⬇️
.../frontend/src/optimizer/plan_node/logical_apply.rs 85.92% <41.37%> (-5.75%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit b9c919f Jun 12, 2023
@ice1000 ice1000 deleted the tesla/xbb branch June 12, 2023 13:02
@xxchan xxchan removed the user-facing-changes Contains changes that are visible to users label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants