feat(frontend): add StreamMaterialize node #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Mar 17, 2022
|
|
||
| impl fmt::Display for StreamMaterialize { | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| write!(f, "StreamMaterialize") |
There was a problem hiding this comment.
Suggested change
| write!(f, "StreamMaterialize") | |
| f.debug_struct("StreamMaterialize") | |
| // table_id, perhaps | |
| .finish() |
Codecov Report
@@ Coverage Diff @@
## main #1033 +/- ##
=========================================
Coverage 71.86% 71.86%
Complexity 2766 2766
=========================================
Files 995 996 +1
Lines 83549 83581 +32
Branches 1790 1790
=========================================
+ Hits 60039 60063 +24
- Misses 22619 22627 +8
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Alex Chi <[email protected]>
skyzh
force-pushed
the
skyzh/add-materialize-node
branch
from
2e62af8
to
fa84c74
Compare
fuyufjh
approved these changes
Mar 18, 2022
| input: PlanRef, | ||
| schema: Schema, | ||
| table_id: TableId, | ||
| } |
There was a problem hiding this comment.
To complete the MaterializeNode node for compute nodes, it's also necessary to know the column ids of each field in schema as well as the columns of primary keys.
However, I am not sure whether these fields be placed in plan nodes. Let's decide this when working on its to_prost
pangzhenzhou
pushed a commit
that referenced
this pull request
Mar 28, 2022
Signed-off-by: Alex Chi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi [email protected]
What's changed and what's your intention?
As title. Not sure if this is the correct way to add MaterializeNode...
Constructing this node also requires a ctx. Now we get the ctx from logical node.
Checklist
Refer to a related PR or issue link (optional)
ref #961