feat(expr): date_trunc
, extract
, date_part
with implicit timezone
#10480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support the following:
date_trunc(field_string, input_timestamptz) = timestamptz
extract(field_string, input_timestamptz) = decimal
date_part(field_string, input_timestamptz) = double precision
by rewriting into the following:
date_trunc(field_string, input_timestamptz, zone_string) = timestamptz
extract(field_string, input_timestamptz, zone_string) = decimal
(not in PostgreSQL)date_part(field_string, input_timestamptz, zone_string) = double precision
(not in PostgreSQL)Related: #10410
Breaking change: Due to the addition of
date_trunc(field_string, input_timestamptz)
, it is chosen as the preferred overload wheninput
is actuallydate
. Old query plans continue working because the choice is recorded in the plan with a cast totimestamp
. New plans will cast totimestamptz
. Some old sqls (maybe saved as views) may fail to bind and requires type adjustments.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Types of user-facing changes
Release note
Support the following:
date_trunc(field_string, input_timestamptz) = timestamptz
extract(field_string, input_timestamptz) = decimal
date_part(field_string, input_timestamptz) = double precision