Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): implement create & drop materialized source for catalog v2 #1065

Merged
merged 5 commits into from
Mar 18, 2022

Conversation

BugenZhao
Copy link
Member

What's changed and what's your intention?

As title, note that "materialized source" is specifically table_v2 now.

Checklist

  • I have written necessary docs and comments

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #1065 (38ac384) into main (30b5c02) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1065      +/-   ##
============================================
- Coverage     71.75%   71.70%   -0.06%     
  Complexity     2766     2766              
============================================
  Files           995      996       +1     
  Lines         83683    83810     +127     
  Branches       1790     1790              
============================================
+ Hits          60049    60098      +49     
- Misses        22743    22821      +78     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 74.20% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/meta/src/rpc/service/catalog_service_v2.rs 0.00% <0.00%> (ø)
rust/batch/src/task/env.rs 29.62% <0.00%> (-5.56%) ⬇️
rust/batch/src/executor/mod.rs 82.14% <0.00%> (-5.36%) ⬇️
rust/connector/src/filesystem/file_common.rs 80.71% <0.00%> (-0.45%) ⬇️
rust/common/src/array/mod.rs 69.85% <0.00%> (-0.29%) ⬇️
rust/common/src/types/ordered_float.rs 22.31% <0.00%> (-0.20%) ⬇️
rust/common/src/catalog/schema.rs 79.56% <0.00%> (ø)
rust/frontend/src/optimizer/plan_node/mod.rs 64.40% <0.00%> (ø)
...tend/src/optimizer/plan_node/stream_materialize.rs 66.66% <0.00%> (ø)
rust/frontend/src/optimizer/mod.rs 97.50% <0.00%> (+0.04%) ⬆️
... and 6 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! LGTM!!!!

@BugenZhao BugenZhao merged commit 2dec38f into main Mar 18, 2022
@BugenZhao BugenZhao deleted the bz/create-materialized-source-rpc-part-2 branch March 18, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meta: create & drop materialized source in ddl v2 service
3 participants