Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor changes to show cluster syntax #10932

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jul 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title and suggested by @neverchanje , changed from SHOW CLUSTERS to SHOW CLUSTER.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label Jul 13, 2023
@neverchanje
Copy link
Contributor

neverchanje commented Jul 13, 2023

You may want to merge it into the v1.0 branch to avoid claiming the breaking change in our next version. It'd still be fine if so.

@github-actions github-actions bot added user-facing-changes Contains changes that are visible to users and removed user-facing-changes Contains changes that are visible to users labels Jul 13, 2023
@yezizp2012
Copy link
Contributor Author

You may want to merge it into the v1.0 branch to avoid claiming the breaking change in our next version. It'd still be fine if so.

Yes sure, I added the need-cherry-pick-v1.0 label for it.

@yezizp2012 yezizp2012 added this pull request to the merge queue Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #10932 (437d265) into main (88ecdf8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #10932      +/-   ##
==========================================
- Coverage   69.92%   69.92%   -0.01%     
==========================================
  Files        1309     1309              
  Lines      223841   223841              
==========================================
- Hits       156515   156511       -4     
- Misses      67326    67330       +4     
Flag Coverage Δ
rust 69.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/src/ast/mod.rs 85.03% <0.00%> (ø)
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
src/sqlparser/src/parser.rs 86.06% <ø> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 40a7e8f Jul 14, 2023
5 of 6 checks passed
@yezizp2012 yezizp2012 deleted the chore/alter-show-cluster-cmd branch July 14, 2023 11:49
lmatz pushed a commit that referenced this pull request Jul 14, 2023
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants