Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): clickhouse sink #11240

Merged
merged 13 commits into from
Aug 11, 2023
Merged

feat(sink): clickhouse sink #11240

merged 13 commits into from
Aug 11, 2023

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Jul 26, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support clickhouse sink .

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

- [ ] My PR contains user-facing changes.

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@xxhZs xxhZs marked this pull request as ready for review July 26, 2023 11:16
@xxhZs xxhZs requested a review from wenym1 July 26, 2023 11:16
@xxhZs xxhZs changed the title feat(sink): clickhouse sink v2 feat(sink): clickhouse sink Jul 26, 2023
@tabVersion tabVersion self-requested a review August 4, 2023 08:56
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #11240 (ccc6592) into main (0bdde0e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #11240      +/-   ##
==========================================
- Coverage   70.30%   70.29%   -0.02%     
==========================================
  Files        1359     1359              
  Lines      227162   227191      +29     
==========================================
- Hits       159716   159710       -6     
- Misses      67446    67481      +35     
Flag Coverage Δ
rust 70.29% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/connector/src/sink/clickhouse.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/connector/Cargo.toml Outdated Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Outdated Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Outdated Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Outdated Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Show resolved Hide resolved
src/connector/src/sink/clickhouse.rs Show resolved Hide resolved
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/connector/Cargo.toml Outdated Show resolved Hide resolved
@xxhZs xxhZs added this pull request to the merge queue Aug 11, 2023
Merged via the queue into main with commit cfa7a52 Aug 11, 2023
7 checks passed
@xxhZs xxhZs deleted the xxh/clickhouse_sink_rust_new branch August 11, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants