Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (step 3.2) change all pg catalogs to views upon rw system tables #11334

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jul 31, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #11005 . Introduced some other system tables and views:

  1. rw_relations: a view that shows all relations in the database.
  2. rw_system_tables: a table that contains all system tables in the database.
  3. rw_types: a table that contains all supported types in risingwave.
  4. rw_user_secrets: a table that contains all user encrypted password info, which is only readable by super users.
  5. rw_columns: a table that contains all columns of existing relations except source and sink.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

@github-actions github-actions bot added user-facing-changes Contains changes that are visible to users and removed user-facing-changes Contains changes that are visible to users labels Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #11334 (177192e) into main (d55af54) will increase coverage by 0.70%.
Report is 15 commits behind head on main.
The diff coverage is 95.85%.

@@            Coverage Diff             @@
##             main   #11334      +/-   ##
==========================================
+ Coverage   69.80%   70.50%   +0.70%     
==========================================
  Files        1359     1365       +6     
  Lines      225645   225637       -8     
==========================================
+ Hits       157508   159083    +1575     
+ Misses      68137    66554    -1583     
Flag Coverage Δ
rust 70.50% <95.85%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...alog/system_catalog/rw_catalog/rw_relation_info.rs 32.30% <ø> (+32.30%) ⬆️
src/batch/src/task/task_execution.rs 55.02% <33.33%> (-0.28%) ⬇️
...rc/catalog/system_catalog/rw_catalog/rw_indexes.rs 64.70% <63.63%> (+64.70%) ⬆️
...talog/system_catalog/rw_catalog/rw_user_secrets.rs 78.37% <78.37%> (ø)
...talog/system_catalog/information_schema/columns.rs 100.00% <100.00%> (ø)
...atalog/system_catalog/information_schema/tables.rs 100.00% <100.00%> (ø)
src/frontend/src/catalog/system_catalog/mod.rs 94.19% <100.00%> (+35.34%) ⬆️
.../catalog/system_catalog/pg_catalog/pg_attribute.rs 100.00% <100.00%> (+100.00%) ⬆️
...d/src/catalog/system_catalog/pg_catalog/pg_cast.rs 100.00% <100.00%> (+100.00%) ⬆️
.../src/catalog/system_catalog/pg_catalog/pg_class.rs 100.00% <100.00%> (+100.00%) ⬆️
... and 11 more

... and 55 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the user-facing-changes Contains changes that are visible to users label Jul 31, 2023
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm. It does look like we need more tests though.

@yezizp2012 yezizp2012 added this pull request to the merge queue Aug 2, 2023
Merged via the queue into main with commit e0b25af Aug 2, 2023
5 of 6 checks passed
@yezizp2012 yezizp2012 deleted the refactor/sys-table-step3.2 branch August 2, 2023 03:46
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants