Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): parse [!]~~[*] operators to [NOT] [I]LIKE #11748

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Aug 17, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

And enable some tests

Related: #11743 #11496

Also enable some regress tests

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support ~~/~~*/!~~/!~~*

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

src/tests/regress/data/sql/strings.sql Outdated Show resolved Hide resolved
@TennyZhuang TennyZhuang added this pull request to the merge queue Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #11748 (604b363) into main (2ebb278) will decrease coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #11748      +/-   ##
==========================================
- Coverage   70.30%   70.29%   -0.01%     
==========================================
  Files        1366     1366              
  Lines      228288   228307      +19     
==========================================
+ Hits       160488   160499      +11     
- Misses      67800    67808       +8     
Flag Coverage Δ
rust 70.29% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/sqlparser/src/parser.rs 86.43% <100.00%> (+0.01%) ⬆️
src/sqlparser/src/tokenizer.rs 93.78% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit cf56e72 Aug 17, 2023
6 of 7 checks passed
@TennyZhuang TennyZhuang deleted the parser-double-tilde branch August 17, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants