Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(handler): support [I]LIKE in show commands #11791

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Conversation

TennyZhuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

support [I]LIKE in show commands

Signed-off-by: TennyZhuang <[email protected]>
Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang added this pull request to the merge queue Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #11791 (363b967) into main (a57c34c) will decrease coverage by 0.02%.
The diff coverage is 67.69%.

@@            Coverage Diff             @@
##             main   #11791      +/-   ##
==========================================
- Coverage   70.23%   70.21%   -0.02%     
==========================================
  Files        1371     1371              
  Lines      228344   228392      +48     
==========================================
- Hits       160370   160369       -1     
- Misses      67974    68023      +49     
Flag Coverage Δ
rust 70.21% <67.69%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/frontend/src/session.rs 29.93% <0.00%> (-0.08%) ⬇️
src/utils/pgwire/src/pg_response.rs 53.10% <ø> (ø)
src/frontend/src/handler/show.rs 28.28% <55.55%> (+0.97%) ⬆️
src/sqlparser/src/parser.rs 86.34% <72.97%> (-0.09%) ⬇️
src/frontend/src/handler/mod.rs 59.31% <100.00%> (+0.25%) ⬆️
src/sqlparser/src/ast/mod.rs 85.32% <100.00%> (+0.49%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 41b8d6f Aug 21, 2023
6 of 7 checks passed
@TennyZhuang TennyZhuang deleted the show-objects-filter branch August 21, 2023 05:37
@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label Aug 21, 2023
Li0k pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants