Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sink): support redis sink #11999

Merged
merged 11 commits into from
Oct 23, 2023

Merge branch 'main' into xxh/redis-sink

3fbcaa9
Select commit
Loading
Failed to load commit list.
Merged

feat(Sink): support redis sink #11999

Merge branch 'main' into xxh/redis-sink
3fbcaa9
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Oct 23, 2023 in 0s

4 / 4 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
I have written necessary rustdoc comments Completed
I have added necessary unit tests and integration tests Completed
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Completed
candidate name: text_tmpl Incomplete
related: #11370 Incomplete
problems: if the user forget to use a column in keyformat, different rw keys would map to same redis key; if the user does not use a column in valueformat, the column is better pruned during planning phase. Incomplete
candidate name: colon_seperated_value Incomplete
candidate name: csv_inside_bracket Incomplete
We don't need to handle all columns. Only the column on the template string should be used for replace. Incomplete
the current implementation should process the template string for each row, but actually we only need to process and compile the template string as something like a regrex, and then apply the row value to the compiled one. Incomplete