Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parallelism column in rw_fragments #12901

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Oct 17, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #12841 .

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

add column parallelism in system table rw_fragments.

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #12901 (e544ffc) into main (527a276) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main   #12901   +/-   ##
=======================================
  Coverage   69.17%   69.18%           
=======================================
  Files        1489     1489           
  Lines      246069   246072    +3     
=======================================
+ Hits       170230   170243   +13     
+ Misses      75839    75829   -10     
Flag Coverage Δ
rust 69.18% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../catalog/system_catalog/rw_catalog/rw_fragments.rs 50.00% <50.00%> (ø)
src/meta/src/rpc/service/stream_service.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yezizp2012 yezizp2012 added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit 1f151cd Oct 17, 2023
36 of 37 checks passed
@yezizp2012 yezizp2012 deleted the feat/expose-fragment-parallelism branch October 17, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extend rw_fragments to let it show more user-facing information
2 participants