Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): support dml subquery #12995

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 23, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  • Support using subqueries(EXISTS, IN, ...) in update and delete statements.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #12995 (4f23792) into main (19643ad) will decrease coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #12995      +/-   ##
==========================================
- Coverage   68.78%   68.77%   -0.01%     
==========================================
  Files        1495     1495              
  Lines      250092   250096       +4     
==========================================
- Hits       172014   172008       -6     
- Misses      78078    78088      +10     
Flag Coverage Δ
rust 68.77% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/planner/delete.rs 72.50% <100.00%> (ø)
src/frontend/src/planner/select.rs 93.90% <100.00%> (+0.08%) ⬆️
src/frontend/src/planner/update.rs 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenzl25 chenzl25 added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit ebfafe5 Oct 23, 2023
28 of 29 checks passed
@chenzl25 chenzl25 deleted the dylan/support_dml_subquery branch October 23, 2023 06:03
@fuyufjh
Copy link
Member

fuyufjh commented Oct 23, 2023

I think it's user-facing? At least worth to mention in release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InternalError_: Panicked when processing: internal error: entered unreachable code: Subquery Subquery
5 participants