build(release): release risingwave all-in-one #13133
Conversation
ci/scripts/release.sh
Outdated
| exit 1 | ||
| fi | ||
| fi | ||
| #echo "--- Check risingwave release version" |
There was a problem hiding this comment.
Just to get the test to pass temporarily.
ci/scripts/release.sh
Outdated
| @@ -92,6 +94,10 @@ if [[ -n "${BUILDKITE_TAG}" ]]; then | |||
|
|
|||
| echo "--- Release build and upload risingwave connector node jar asset" | |||
| gh release upload "${BUILDKITE_TAG}" risingwave-connector-"${BUILDKITE_TAG}".tar.gz | |||
|
|
|||
| echo "--- Release upload risingwave-all-in-one asset" | |||
| tar -czvf risingwave-all-in-one-"${BUILDKITE_TAG}"-x86_64-unknown-linux.tar.gz risingwave libs | |||
There was a problem hiding this comment.
Do we consider setting a default lib path relative to the risingwave binary in jvm initialization so that users don't need to explicitly set the env var when they want to extract the tar and run directly?
There was a problem hiding this comment.
Make senses. We can use a default lib path when the environment variable CONNECTOR_LIBS_PATH is not set.
Codecov Report
@@ Coverage Diff @@
## main #13133 +/- ##
==========================================
- Coverage 68.27% 68.25% -0.03%
==========================================
Files 1499 1500 +1
Lines 252602 252691 +89
==========================================
+ Hits 172459 172465 +6
- Misses 80143 80226 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "environment variable CONNECTOR_LIBS_PATH is not specified".to_string(), | ||
| ) | ||
| .into()); | ||
| tracing::warn!("environment variable CONNECTOR_LIBS_PATH is not specified, so use default path `./libs` instead"); |
There was a problem hiding this comment.
It's better to join the env.args[0](which is the path of the binary) and ./libs to get the path. The current way only works correctly when pwd is the same as the directory of risingwave binary (where we can run ./risingwave). If users run as /.../.../risingwave, we may not get the correct libs path.
There was a problem hiding this comment.
TennyZhuang
changed the title
TennyZhuang
changed the title
chenzl25
added
the
user-facing-changes
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.