Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine to_rw_result_with #1470

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Mar 31, 2022

What's changed and what's your intention?

As title, keep it since extra context is useful for debugging.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Resolve #1442

rust/common/src/error.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1470 (573b7aa) into main (555ff16) will decrease coverage by 0.00%.
The diff coverage is 38.46%.

@@             Coverage Diff              @@
##               main    #1470      +/-   ##
============================================
- Coverage     70.23%   70.22%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1028     1028              
  Lines         90178    90181       +3     
  Branches       1790     1790              
============================================
- Hits          63337    63334       -3     
- Misses        25950    25956       +6     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.19% <38.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/batch/src/task/broadcast_channel.rs 0.00% <0.00%> (ø)
rust/batch/src/task/fifo_channel.rs 75.00% <0.00%> (ø)
rust/batch/src/task/hash_shuffle_channel.rs 0.00% <0.00%> (ø)
rust/meta/src/barrier/recovery.rs 0.00% <0.00%> (ø)
rust/rpc_client/src/meta_client.rs 0.00% <0.00%> (ø)
rust/rpc_client/src/compute_client.rs 66.66% <42.85%> (-3.55%) ⬇️
rust/meta/src/stream/stream_manager.rs 75.83% <75.00%> (ø)
rust/batch/src/rpc/service/exchange.rs 96.77% <100.00%> (ø)
rust/common/src/error.rs 72.39% <100.00%> (ø)
rust/meta/src/manager/stream_clients.rs 96.29% <100.00%> (ø)
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit 9d7059d into main Mar 31, 2022
@yezizp2012 yezizp2012 deleted the chore/refine-to_rw_result_with branch March 31, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate to_rw_result_with
3 participants