Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(streaming): add unit tests for chain v2 #1491

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Mar 31, 2022

Signed-off-by: Bugen Zhao [email protected]

What's changed and what's your intention?

As title. This PR also adds a flag for "sending a stop barrier on stream finish" for MockSource.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@github-actions github-actions bot added the component/test Test related issue. label Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #1491 (8247e44) into main (1d13c51) will increase coverage by 0.05%.
The diff coverage is 94.59%.

@@             Coverage Diff              @@
##               main    #1491      +/-   ##
============================================
+ Coverage     70.46%   70.51%   +0.05%     
  Complexity     2766     2766              
============================================
  Files          1029     1029              
  Lines         90259    90333      +74     
  Branches       1790     1790              
============================================
+ Hits          63598    63701     +103     
+ Misses        25770    25741      -29     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.54% <94.59%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/stream/src/executor_v2/test_utils.rs 59.32% <88.88%> (+19.32%) ⬆️
rust/stream/src/executor_v2/chain.rs 75.45% <95.38%> (+75.45%) ⬆️
rust/connector/src/filesystem/file_common.rs 81.16% <0.00%> (+0.44%) ⬆️
rust/stream/src/executor/mod.rs 61.22% <0.00%> (+1.63%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao BugenZhao requested a review from fuyufjh March 31, 2022 11:41
@BugenZhao BugenZhao enabled auto-merge (squash) March 31, 2022 11:41
@BugenZhao BugenZhao merged commit 9b0de22 into main Mar 31, 2022
@BugenZhao BugenZhao deleted the bz/add-ut-for-chain-v2 branch March 31, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants