Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move benchmark tool docs #1513

Merged
merged 3 commits into from
Apr 1, 2022
Merged

docs: move benchmark tool docs #1513

merged 3 commits into from
Apr 1, 2022

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Apr 1, 2022

What's changed and what's your intention?

Move docs/developer/benchmark_tool/state_store.md to rust/bench/ss_bench/README.md.

Checklist

N/A

Refer to a related PR or issue link (optional)

None

@github-actions github-actions bot added the component/doc Issues about documentation. label Apr 1, 2022
@fuyufjh fuyufjh enabled auto-merge (squash) April 1, 2022 05:00
@Sunt-ing Sunt-ing disabled auto-merge April 1, 2022 05:02
@Sunt-ing
Copy link
Contributor

Sunt-ing commented Apr 1, 2022

Please change the link mentioned in rust/bench/ss_bench/main.rs

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #1513 (b98b4bc) into main (b00df18) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1513      +/-   ##
============================================
+ Coverage     70.44%   70.45%   +0.01%     
  Complexity     2766     2766              
============================================
  Files          1031     1031              
  Lines         90471    90493      +22     
  Branches       1790     1790              
============================================
+ Hits          63735    63761      +26     
+ Misses        25845    25841       -4     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 72.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/bench/ss_bench/main.rs 0.98% <ø> (ø)
rust/frontend/src/expr/subquery.rs 48.27% <0.00%> (-3.58%) ⬇️
rust/sqlparser/src/parser.rs 92.63% <0.00%> (+0.04%) ⬆️
...rontend/src/optimizer/plan_node/logical_project.rs 97.24% <0.00%> (+0.04%) ⬆️
rust/sqlparser/src/tokenizer.rs 93.61% <0.00%> (+0.11%) ⬆️
...st/frontend/src/optimizer/plan_node/logical_agg.rs 97.63% <0.00%> (+0.20%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️
rust/frontend/src/binder/expr/binary_op.rs 93.93% <0.00%> (+3.03%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@fuyufjh fuyufjh enabled auto-merge (squash) April 1, 2022 05:15
@skyzh
Copy link
Contributor

skyzh commented Apr 1, 2022

We can also have ToCs for READMEs of independent tools in CONTRIBUTING.md. IIRC, we have ss_bench, risedev, and planner-test

Copy link
Contributor

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh fuyufjh merged commit 0156778 into main Apr 1, 2022
@fuyufjh fuyufjh deleted the eric/move_bench_docs branch April 1, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants