feat(meta): support create subscription #15371
Conversation
There was a problem hiding this comment.
Rest generally LGTM, thx for the job. Since so many syntaxes are supported for subscription, we need enough e2e to cover them in later PRs. Cc @zwang28 do we need some extra works to support backup functions based on etcd?
| @@ -65,6 +65,7 @@ message GrantPrivilege { | |||
| uint32 all_tables_schema_id = 11; | |||
| uint32 all_sources_schema_id = 12; | |||
| uint32 all_dml_tables_schema_id = 13; | |||
| uint32 subscription_id = 14; | |||
There was a problem hiding this comment.
FYI, non-related to this PR, we also have to define all available acls for subscription in https:/risingwavelabs/risingwave/blob/be30f20e2c14b5d12efd5b33a4ac9e537602fc37/src/common/src/acl/mod.rs and support privilege related syntax for subscription. We can support it in an separate PR after the functionality of subscription is ready.
yesyes,I will add e2e in part2 |
hzxa21
changed the title
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Changes in meta to support create subscription.
Follow-up PR: frontend changes in #14831
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.