Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move Cargo.toml to root #1580

Merged
merged 10 commits into from
Apr 3, 2022
Merged

feat: Move Cargo.toml to root #1580

merged 10 commits into from
Apr 3, 2022

Conversation

liurenjie1024
Copy link
Contributor

What's changed and what's your intention?

RT.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Closes #1572

@liurenjie1024 liurenjie1024 requested a review from skyzh April 3, 2022 07:52
@liurenjie1024 liurenjie1024 enabled auto-merge (squash) April 3, 2022 07:53
@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1580 (b6e7537) into main (0f2d391) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1580      +/-   ##
============================================
- Coverage     69.70%   69.70%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1042     1042              
  Lines         91601    91601              
  Branches       1790     1790              
============================================
- Hits          63852    63850       -2     
- Misses        26858    26860       +2     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.52% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/filesystem/file_common.rs 80.26% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve as long as it pass CI

@liurenjie1024 liurenjie1024 merged commit 9f48392 into main Apr 3, 2022
@liurenjie1024 liurenjie1024 deleted the fix/cargo_root branch April 3, 2022 11:17
@TennyZhuang TennyZhuang mentioned this pull request Apr 4, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misc: move Cargo.toml to root directory
2 participants