Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix window_start type #1601

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

TennyZhuang
Copy link
Contributor

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

  1. fix the return type of tumble_start_date.
  2. fix the type in binder and planner.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Close #1600

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1601 (0b2611d) into main (1e321f1) will increase coverage by 0.00%.
The diff coverage is 64.70%.

@@            Coverage Diff            @@
##               main    #1601   +/-   ##
=========================================
  Coverage     69.89%   69.90%           
  Complexity     2766     2766           
=========================================
  Files          1041     1041           
  Lines         91744    91734   -10     
  Branches       1790     1790           
=========================================
+ Hits          64122    64123    +1     
+ Misses        26731    26720   -11     
  Partials        891      891           
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.75% <64.70%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/expr_binary_nonnull.rs 77.73% <0.00%> (ø)
src/expr/src/vector_op/tumble.rs 78.04% <0.00%> (+14.04%) ⬆️
src/frontend/src/binder/window_table_function.rs 68.60% <100.00%> (-2.05%) ⬇️
src/frontend/src/expr/type_inference.rs 93.48% <100.00%> (+0.12%) ⬆️
src/frontend/src/planner/relation.rs 89.87% <100.00%> (-0.26%) ⬇️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️
src/connector/src/filesystem/file_common.rs 81.16% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TennyZhuang TennyZhuang merged commit 1d831db into main Apr 6, 2022
@TennyZhuang TennyZhuang deleted the fix/tumble-start-type branch April 6, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TVF: fix type of window_start
2 participants