Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): batch query executor v2 #1619

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Apr 6, 2022

What's changed and what's your intention?

As title. This PR also hacks on the v1-compat to mimic the behavior for init, ErrorCode::Eof, etc.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao marked this pull request as ready for review April 7, 2022 04:07
@BugenZhao BugenZhao requested review from MrCroxx, lmatz and wcy-fdu and removed request for MrCroxx April 7, 2022 04:07
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1619 (1d133b3) into main (8d9be07) will decrease coverage by 0.02%.
The diff coverage is 55.04%.

@@             Coverage Diff              @@
##               main    #1619      +/-   ##
============================================
- Coverage     69.78%   69.76%   -0.03%     
  Complexity     2766     2766              
============================================
  Files          1049     1050       +1     
  Lines         92213    92214       +1     
  Branches       1790     1790              
============================================
- Hits          64351    64333      -18     
- Misses        26971    26990      +19     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.58% <55.04%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/batch_query.rs 0.00% <0.00%> (-55.23%) ⬇️
src/stream/src/executor_v2/error.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/v1_compat.rs 44.11% <16.00%> (-5.20%) ⬇️
src/stream/src/executor_v2/mod.rs 55.81% <35.29%> (-18.27%) ⬇️
src/stream/src/executor_v2/batch_query.rs 81.96% <81.96%> (ø)
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao enabled auto-merge (squash) April 7, 2022 04:44
@BugenZhao BugenZhao merged commit db97073 into main Apr 7, 2022
@BugenZhao BugenZhao deleted the bz/batch-query-executor-v2 branch April 7, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants