Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tracking issue to NotImplementedError #1639

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Apr 7, 2022

Signed-off-by: TennyZhuang [email protected]

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  1. rename NotImplementedError to NotImplemented
  2. add tracking issue number to NotImplemented

image

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Contributor

@twocode twocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cool!

Signed-off-by: TennyZhuang <[email protected]>
@TennyZhuang TennyZhuang enabled auto-merge (squash) April 7, 2022 05:52
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1639 (e80e460) into main (7d7c75b) will decrease coverage by 0.02%.
The diff coverage is 31.81%.

@@             Coverage Diff              @@
##               main    #1639      +/-   ##
============================================
- Coverage     69.83%   69.80%   -0.03%     
  Complexity     2766     2766              
============================================
  Files          1050     1050              
  Lines         92385    92459      +74     
  Branches       1790     1790              
============================================
+ Hits          64516    64543      +27     
- Misses        26978    27025      +47     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.62% <31.81%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/expr/build_expr_from_prost.rs 69.71% <0.00%> (ø)
src/expr/src/expr/expr_input_ref.rs 72.00% <0.00%> (ø)
src/expr/src/expr/expr_unary.rs 75.96% <0.00%> (ø)
src/frontend/src/binder/expr/subquery.rs 83.33% <0.00%> (ø)
src/frontend/src/binder/expr/value.rs 87.15% <0.00%> (ø)
src/frontend/src/binder/insert.rs 86.11% <0.00%> (-5.07%) ⬇️
src/frontend/src/binder/relation.rs 86.20% <0.00%> (ø)
src/frontend/src/binder/set_expr.rs 66.66% <0.00%> (ø)
src/frontend/src/binder/statement.rs 68.42% <0.00%> (-8.05%) ⬇️
src/frontend/src/expr/agg_call.rs 41.55% <0.00%> (ø)
... and 17 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@BugenZhao
Copy link
Member

Cool. We can migrate some unimplemented!() to this as well.

@TennyZhuang
Copy link
Contributor Author

Cool. We can migrate some unimplemented!() to this as well.

Agree, but I need some help

@TennyZhuang TennyZhuang merged commit 48d4f94 into main Apr 7, 2022
@TennyZhuang TennyZhuang deleted the chore/add-tracking-issue-to-not-implemented branch April 7, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants