feat: skip rw's generated column when validating source #16522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
commented
Apr 28, 2024
| @@ -181,16 +197,4 @@ impl<T: CdcSourceTypeTrait> CdcProperties<T> { | |||
| pub fn get_source_type_pb(&self) -> SourceType { | |||
| SourceType::from(T::source_type()) | |||
| } | |||
|
|
|||
| pub fn schema(&self) -> Schema { | |||
There was a problem hiding this comment.
this function is not used.
tabVersion
approved these changes
Apr 28, 2024
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 7ac0aa0 | e2e_test/source/cdc/cdc.validate.postgres.slt | View secret |
| 9425213 | Triggered | Generic Password | 1f9eb51 | e2e_test/source/cdc/cdc.validate.postgres.slt | View secret |
| 9425213 | Triggered | Generic Password | 1f9eb51 | e2e_test/source/cdc/cdc.validate.postgres.slt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
xiangjinwu
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The generated column is produced in risingwave rather than accessed from the external connector. So during the validation, the columns should be ignore.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
support generated column for non-shared CDC table.