Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): support kafka and zookeeper #1690

Merged
merged 3 commits into from
Apr 8, 2022
Merged

feat(risedev): support kafka and zookeeper #1690

merged 3 commits into from
Apr 8, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 8, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1690 (152708a) into main (d230334) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1690      +/-   ##
============================================
- Coverage     69.76%   69.42%   -0.34%     
  Complexity     2766     2766              
============================================
  Files          1054     1058       +4     
  Lines         92875    93326     +451     
  Branches       1790     1790              
============================================
- Hits          64793    64792       -1     
- Misses        27191    27643     +452     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.14% <0.00%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/bin/risedev-config.rs 0.45% <0.00%> (-0.02%) ⬇️
src/risedevtool/src/bin/risedev-playground.rs 0.25% <0.00%> (-0.02%) ⬇️
src/risedevtool/src/config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config/service_config.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/kafka_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/config_gen/zookeeper_gen.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task.rs 0.00% <ø> (ø)
src/risedevtool/src/task/etcd_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/kafka_service.rs 0.00% <0.00%> (ø)
src/risedevtool/src/task/minio_service.rs 0.00% <0.00%> (ø)
... and 7 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh enabled auto-merge (squash) April 8, 2022 06:06
@skyzh skyzh merged commit a00d294 into main Apr 8, 2022
@skyzh skyzh deleted the skyzh/risedev-kafka branch April 8, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants