Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(batch): remove unnecessary logs #1716

Merged
merged 2 commits into from
Apr 8, 2022
Merged

chore(batch): remove unnecessary logs #1716

merged 2 commits into from
Apr 8, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 8, 2022

Signed-off-by: Alex Chi [email protected]

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@skyzh skyzh enabled auto-merge (squash) April 8, 2022 10:55
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1716 (adb3344) into main (c2724f0) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main    #1716      +/-   ##
==========================================
- Coverage   71.31%   71.30%   -0.01%     
==========================================
  Files         599      599              
  Lines       77664    77662       -2     
==========================================
- Hits        55386    55377       -9     
- Misses      22278    22285       +7     
Flag Coverage Δ
rust 71.30% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/hash_join.rs 84.00% <ø> (-0.05%) ⬇️
src/batch/src/task/task_.rs 37.70% <ø> (ø)
src/compute/src/rpc/service/exchange_service.rs 0.00% <0.00%> (ø)
src/utils/logging/src/lib.rs 0.78% <0.00%> (ø)
src/batch/src/executor/row_seq_scan.rs 61.72% <66.66%> (ø)
src/batch/src/task/task_manager.rs 82.20% <100.00%> (ø)
src/common/src/array/data_chunk.rs 94.67% <0.00%> (-2.29%) ⬇️
src/common/src/array/data_chunk_iter.rs 84.29% <0.00%> (-0.53%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️
src/connector/src/filesystem/file_common.rs 80.80% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh merged commit 60bd627 into main Apr 8, 2022
@skyzh skyzh deleted the skyzh/check-log-size branch April 8, 2022 13:01
@xxchan xxchan mentioned this pull request Jun 7, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants